Skip to content

Stop autoloading favourite templates option#3136

Merged
Crabcyborg merged 1 commit into
masterfrom
stop_autoloading_favourite_templates_option
Jun 11, 2026
Merged

Stop autoloading favourite templates option#3136
Crabcyborg merged 1 commit into
masterfrom
stop_autoloading_favourite_templates_option

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Jun 11, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Optimized storage mechanism for favorite templates preference.

Note: This is a technical optimization with no visible changes to end-user functionality.

@Crabcyborg Crabcyborg added this to the 6.32 milestone Jun 11, 2026
@coderabbitai

coderabbitai Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8705a58a-51e1-4dfe-8d7a-6c3358f63a11

📥 Commits

Reviewing files that changed from the base of the PR and between 0a52357 and 494b3dd.

📒 Files selected for processing (1)
  • classes/controllers/FrmFormTemplatesController.php
📝 Walkthrough

Walkthrough

A single parameter adjustment to the update_option() call in the favorite templates controller method. The frm_favorite_templates option now explicitly disables autoload when stored, preventing WordPress from loading it automatically on every request.

Changes

Favorite Templates Persistence

Layer / File(s) Summary
Autoload parameter for favorite templates option
classes/controllers/FrmFormTemplatesController.php		 The update_option() call for FAVORITE_TEMPLATES_OPTION now passes false as the autoload parameter, preventing WordPress from automatically loading the favorite templates preference on every page load.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A favorite saved, now light and lean,
No autoload burden in between!
One swift change, WordPress made wise—
Templates preferred, without the surprise.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding the autoload parameter to update_option() to prevent autoloading of the frm_favorite_templates option.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stop_autoloading_favourite_templates_option

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@deepsource-io

deepsource-io Bot commented Jun 11, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 0a52357...494b3dd on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Jun 11, 2026 5:00p.m. Review ↗
JavaScript Jun 11, 2026 5:00p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@deepsource-io

deepsource-io Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 0a52357...494b3dd on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Jun 11, 2026 5:00p.m. Review ↗
JavaScript Jun 11, 2026 5:00p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@Crabcyborg
Crabcyborg merged commit 325c734 into master Jun 11, 2026
46 of 48 checks passed
@Crabcyborg
Crabcyborg deleted the stop_autoloading_favourite_templates_option branch June 11, 2026 17:03
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.43%. Comparing base (28638a6) to head (494b3dd).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #3136   +/-   ##
=========================================
  Coverage     26.43%   26.43%           
- Complexity     9246     9247    +1     
=========================================
  Files           149      149           
  Lines         31042    31044    +2     
=========================================
+ Hits           8205     8206    +1     
- Misses        22837    22838    +1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

run analysis run tests

Projects

None yet

Milestone

6.32

Development

Successfully merging this pull request may close these issues.

1 participant

@Crabcyborg